Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement and rewrite tests - #1577
Open
KhotKeys wants to merge 6 commits into
Open
Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement and rewrite tests#1577KhotKeys wants to merge 6 commits into
KhotKeys wants to merge 6 commits into
Conversation
KhotKeys
added
📅 Sprint 3
cjyuan
reviewed
Jul 27, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
Just two comments.
| // TODO: Implement this function | ||
| const suit = card.slice(-1); | ||
| const rank = card.slice(0, -1); | ||
| const validSuits = ["\u2660", "\u2665", "\u2666", "\u2663"]; |
Contributor
There was a problem hiding this comment.
Why not just specify the suit characters as "♠", "♥", "♦", "♣"?
Comment on lines
+12
to
+25
| test(`should return false when numerator >= denominator`, () => { | ||
| expect(isProperFraction(2, 1)).toEqual(false); | ||
| expect(isProperFraction(3, 3)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should handle negative numerator`, () => { | ||
| expect(isProperFraction(-1, 2)).toEqual(true); | ||
| expect(isProperFraction(-3, 2)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should handle negative denominator`, () => { | ||
| expect(isProperFraction(1, -2)).toEqual(true); | ||
| expect(isProperFraction(3, -2)).toEqual(false); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could consider using pseudo-code and notations like abs(...) or | ... | in the descriptions to make them more informative and concise.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist